This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
allow buck to be built at newer version of Python #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: See facebook#2696 for another example. In Python 3.3 types like `Sequence` were moved to the `collections.abc` submodule. The aforementioned PR fixed runtime issues, but the bin/buck Python bootstrapping script still failed with non-ancient versions of Python. Test Plan: Built and ran buck1 successfully on my machine.
|
Buck1 is officially dead. From readme:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow buck to be built at newer version of Python
Summary:
See #2696 for another example.
In Python 3.3 types like
Sequencewere moved to thecollections.abcsubmodule. The aforementioned PR fixed runtimeissues, but the bin/buck Python bootstrapping script still failed with
non-ancient versions of Python.
Test Plan: Built and ran buck1 successfully on my machine.